* David Ahern <dsah...@gmail.com> wrote:
> On 11/5/13, 10:36 PM, Ingo Molnar wrote:
> >I think you could avoid the 'short' complication altogether by doing
> >something like this:
> >
> >>+elif test -f ../../PERF-VERSION-FILE
> >>+then
> >>+ TAG=$(cut -d' ' -f3 ../../PERF-VERSION-FILE)
> >
> >That extracts 'TAG' as a true sha1 and makes GVF correct on out of tree
> >builds as well.
>
> Certainly. I was trying to make PERF-VERSION-FILE readable as a
> standalone file -- a better version descriptor than HEAD file.
Do you mean that instead of:
comet:~/tip/tools/perf> cat PERF-VERSION-FILE
#define PERF_VERSION "3.12.g953bfb"
we should put a plain version into it? (the 'short' form you introduced
earlier)
And then this:
Makefile.perf: $(QUIET_CC)$(CC) -include $(OUTPUT)PERF-VERSION-FILE \
Could be replaced with:
Makefile.perf: $(QUIET_CC)$(CC) -D $(shell cat $(OUTPUT)PERF-VERSION-FILE) \
or so?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
