Hi, Guenter Roeck <[email protected]> writes:
> On 11/08/2013 03:31 PM, Arnaud Ebalard wrote: >> >> This patch adds support for GMT G751 Temperature Sensor and Thermal >> Watchdog I2C chip. It has been tested via DT on a Netgear ReadyNAS >> 2120 (Marvell Armada XP based ARM device). >> >> Signed-off-by: Arnaud Ebalard <[email protected]> > > Arnaud, > > unless I am missing something, this is just an lm75 with a different > name. Sadly (for me), you are not: I compared the GMT G751 datasheet to an original (1996) National semiconductor LM75 datasheet and they are identical. I mean both the structure and full content (text, diagrams, etc) is the same. Lesson learned: next time I start a driver, I will ask if it ressembles an existing supported chip beforehand. > Please use the lm75 driver and add the g751 parameters to it. I will test if the driver does indeed work as expected to drive the G751 and will send a patch to document compatibility w/ GMT G751 (Kconfig, i2c_device_id struct and lm75_detect function). While I am at it, if you see something in the patch I pushed which could be useful for current lm75 driver (doc, sysfs, of_ part for polarity, ...), just tell me. Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
