Hi Vinayak, On 13/11/13 11:05, Vinayak Kale wrote: > This patch adds an accessor function for IRQ_PER_CPU flag. > The accessor function is useful to dertermine whether an IRQ is percpu or not. > > Signed-off-by: Vinayak Kale <vk...@apm.com> > --- > include/linux/irqdesc.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h > index 56fb646..acd8a3f 100644 > --- a/include/linux/irqdesc.h > +++ b/include/linux/irqdesc.h > @@ -152,6 +152,14 @@ static inline int irq_balancing_disabled(unsigned int > irq) > return desc->status_use_accessors & IRQ_NO_BALANCING_MASK; > } > > +static inline int irq_is_percpu(unsigned int irq) > +{ > + struct irq_desc *desc; > + > + desc = irq_to_desc(irq); > + return (desc && (desc->status_use_accessors & IRQ_PER_CPU)) ? 1 : 0;
I don't think it is worth checking for the validity of "desc" here. All the other accessors assume that you've not passed a stupid "irq" value. Simply having return !!(desc->status_use_accessors & IRQ_PER_CPU); should be enough. > +} > + > static inline void > irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) > { > Cheers, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/