2013/11/14 Geyslan G. Bem <[email protected]>: > If 'hsr_get_node_data()' returns error, going directly to 'fail' label > doesn't free the memory pointed by 'skb_out'. > > Signed-off-by: Geyslan G. Bem <[email protected]> > --- > net/hsr/hsr_netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c > index 4e66bf6..aef8429 100644 > --- a/net/hsr/hsr_netlink.c > +++ b/net/hsr/hsr_netlink.c > @@ -249,7 +249,7 @@ static int hsr_get_node_status(struct sk_buff *skb_in, > struct genl_info *info) > &hsr_node_if2_age, > &hsr_node_if2_seq); > if (res < 0) > - goto fail; > + goto nla_put_failure; > > res = nla_put(skb_out, HSR_A_NODE_ADDR, ETH_ALEN, > > nla_data(info->attrs[HSR_A_NODE_ADDR])); > -- > 1.8.4.2 >
It's a Coverity catch: CID 1128855. -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
