On Thu, 14 Nov 2013, Luck, Tony wrote: > > ERROR: "boot_cpu_physical_apicid" [drivers/acpi/acpi_extlog.ko] undefined! > > > > The symbol needs to be exported for it to be available. > > Good - but I wonder how many more useless layers there are to this onion :-( > > First I had to add a "#include <asm/cpu.h>" > Then add the dependency on CONFIG_X86_LOCAL_APIC > Now we need to export boot_cpu_physical_apicid >
asm/cpu.h itself is also indirectly relying on asm/topology.h to include asm/mpspec.h to get that declaration of boot_cpu_physical_apicid in the first place. > all for the CONFIG_SMP=n case ... which I think is useless because there > is no conceivable way anyone would run a uniprocessor kernel on a system > that supports the extended error log. (Hint: multi-socket server multiplied by > high-core-count processors multiplied by 2xHyperThread) is a number bigger > than one). > > Perhaps we should just have: > > depends on SMP && X86_MCE > > and stop the madness? > Or do some randconfig testing before patches are proposed :) I don't have any particular dependency on this, so I'm happy with whatever is decided. This is the last error I've found related to CONFIG_ACPI_EXTLOG, however. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
