Nice clean up!!! The code looks much more clean after removing the
duplicated code in all drivers. Thanks.
> diff --git a/drivers/char/tpm/tpm-dev.c b/drivers/char/tpm/tpm-dev.c
> new file mode 100644
> index 0000000..8d94e97
> --- /dev/null
> +++ b/drivers/char/tpm/tpm-dev.c
> + * Copyright (C) 2013 Obsidian Reearch Corp
Typo Research?
> + * Jason Gunthorpe <jguntho...@obsidianresearch.com>
> + *
> +
> +int tpm_dev_add_device(struct tpm_chip *chip)
> +{
> + rc = misc_register(&chip->vendor.miscdev);
> + if (rc) {
> + chip->vendor.miscdev.name = NULL;
> + dev_warn(chip->dev,
Any reason why we use dev_warn here instead of dev_err?
> + "unable to misc_register %s, minor %d err=%d\n",
> + chip->vendor.miscdev.name,
> + chip->vendor.miscdev.minor, rc);
> + }
> + return rc;
> +}
> +
Reviewed-by: Ashley Lai <ad...@linux.vnet.ibm.com>
Regards,
--Ashley Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
