2013/11/17 Arend van Spriel <ar...@broadcom.com>: > On 11/17/13 14:37, Borislav Petkov wrote: >> >> From: Borislav Petkov<b...@suse.de> >> >> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get >> >> drivers/built-in.o: In function `brcms_led_unregister': >> (.text+0x351aca): undefined reference to `led_classdev_unregister' >> drivers/built-in.o: In function `brcms_led_register': >> (.text+0x351c65): undefined reference to `led_classdev_register' >> >> during the final linking stage because brcmsmac/led.c needs LEDS_CLASS >> for reg/dereg. Fix that. > > > Wouldn't it be better to fix it in brcmsmac.
I agree. After all bcma doesn't use/register LEDs, so this should be placed in drivers that do. P.S. Borislav: I think I didn't get your original patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
