On Tue, Jan 18, 2005 at 09:36:45AM +0000, Christoph Hellwig wrote: > On Tue, Jan 18, 2005 at 10:31:58AM +0100, Andi Kleen wrote: > > > - please don't introduce a new API with the BKL held. > > > > Nope, I'm not going to audit zillions of low level functions for this. > > So just stick a lock_kernel() unlock_kernel() into the handler, it's > not like there's more than a handfull of them.
Hmm, possible, although it tends to be quite ugly (requiring either gotos or wrappers). But ok. > > > > - prototype isn't nice. just passing the gendisk for block_device > > > should be enough. > > > > No, it isn't, the compat handler needs cmd and arg, and file is useful > > when you pass it to an existing ioctl handler. > > cmd/arg is needed, file shouldn't. If you care for the underlying handler > add a version that doesn't take the file * either. Sorry, that didn't make any sense. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
