On 11/22, KOSAKI Motohiro wrote: > > (11/22/2013 12:54 PM), Oleg Nesterov wrote: > > next_thread() should be avoided, change check_unsafe_exec() > > to use while_each_thread(). This also saves 32 bytes. > > Just curious. > Why it should be avoided? Just for cleaner code?
Nobody except signal->curr_target actually need next_thread-like code, and > Or is there > serious issue? We need to change (fix) this interface. This particular code is fine, p == current. But in general the code like this can loop forever if p exits and next_thread(t) can't reach the unhashed thread. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
