From: Vlad Yasevich <vyasev...@gmail.com> Date: Thu, 21 Nov 2013 17:14:01 -0500
> On 11/21/2013 04:56 PM, Chang Xiangzhong wrote: >> Function sctp_check_transmitted(transport t, ...) would iterate all of >> transport->transmitted queue and looking for the highest __newly__ acked tsn. >> The original algorithm would depend on the order of the assoc->transport_list >> (in function sctp_outq_sack line 1215 - 1226). The result might not be the >> expected due to the order of the tranport_list. >> >> Solution: checking if the exising is smaller than the new one before >> assigning >> >> Signed-off-by: Chang Xiangzhong <changxiangzh...@gmail.com> > > Good find. This has been around for since day 1. It doesn't so much > depend on the order of the transport list, but on the order the > transports been used. I agree it is a problem if chunks have been > distributed across multiple transports and a singe SACK acking them all. > > Acked-by: Vlad Yasevich <vyasev...@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
