On Tue, Nov 26, 2013 at 2:45 PM, Patrick Farrell <[email protected]> wrote: > Peng, > > I'm sorry to say, this patch was reverted due to interoperability problems > with 2.1 servers (This either a slightly later [but still broken] version of > the patch we discussed recently, or the same one.). If Greg's accepted this > upstream (and it looks like he has), it'll have to be reverted. > Sorry, my bad. I forgot to remove it from my patch queue after we discussed last time. I'll send a reverting patch. Sorry for the noise.
Thanks, Tao > Sorry for the trouble here! > > - Patrick > ________________________________________ > From: Peng Tao [[email protected]] > Sent: Monday, November 25, 2013 8:04 PM > To: Greg Kroah-Hartman > Cc: [email protected]; Patrick Farrell; Cheng Shao; Peng Tao; > Andreas Dilger > Subject: [PATCH 03/16] staging/lustre/nfs: writing to new files will return > ENOENT > > From: Patrick Farrell <[email protected]> > > This happend with SLES11SP2 Lustre client, which in turn acts as an > NFS server, exporting a subtree of an Lustre fs through NFS. > > We detected that whenever we are writing to a new file using, fx, > 'echo blah > newfile', it will return ENOENT error. We found > out that this was caused by the anonymous dentry. In SLESS11SP2, > anonymous dentries are assigned '/' as the name, instead of an > empty string. When MDT handles the intent_open call, it will look > up the obj by the name if it is not an empty string, and thus > couldn't find it. > > As MDS_OPEN_BY_FID is always set on this request, we never need > to send the name in this request. The fid is already available > and should be used in case the file has been renamed. > > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544 > Lustre-change: http://review.whamcloud.com/6920 > Signed-off-by: Cheng Shao <[email protected]> > Signed-off-by: Patrick Farrell <[email protected]> > Reviewed-by: Bob Glossman <[email protected]> > Reviewed-by: Alexey Shvetsov <[email protected]> > Reviewed-by: Lai Siyao <[email protected]> > Reviewed-by: James Simmons <[email protected]> > Reviewed-by: Oleg Drokin <[email protected]> > Signed-off-by: Peng Tao <[email protected]> > Signed-off-by: Andreas Dilger <[email protected]> > --- > drivers/staging/lustre/lustre/llite/file.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c > b/drivers/staging/lustre/lustre/llite/file.c > index 82248e9..f36c5d8 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -368,8 +368,6 @@ static int ll_intent_file_open(struct file *file, void > *lmm, > { > struct ll_sb_info *sbi = ll_i2sbi(file->f_dentry->d_inode); > struct dentry *parent = file->f_dentry->d_parent; > - const char *name = file->f_dentry->d_name.name; > - const int len = file->f_dentry->d_name.len; > struct md_op_data *op_data; > struct ptlrpc_request *req; > __u32 opc = LUSTRE_OPC_ANY; > @@ -394,8 +392,9 @@ static int ll_intent_file_open(struct file *file, void > *lmm, > } > > op_data = ll_prep_md_op_data(NULL, parent->d_inode, > - file->f_dentry->d_inode, name, len, > + file->f_dentry->d_inode, NULL, 0, > O_RDWR, opc, NULL); > + > if (IS_ERR(op_data)) > return PTR_ERR(op_data); > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
