On Wed 27-11-13 18:33:53, Johannes Weiner wrote: [...] > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 13b9d0f..5f9e467 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2675,7 +2675,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm, > goto bypass; > > if (unlikely(task_in_memcg_oom(current))) > - goto bypass; > + goto nomem; > > /* > * We always charge the cgroup the mm_struct belongs to.
Yes, I think we really want this. Plan to send a patch? The first charge failure due to OOM shouldn't be papered over by a later attempt if we didn't get through mem_cgroup_oom_synchronize yet. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/