Hi Lukasz, On 28 November 2013 17:05, Lukasz Majewski <[email protected]> wrote: > To make the driver multiplatform-friendly, unconditional initialization > in an initcall is replaced with a platform driver probed only if > respective platform device is registered. > > Tested at: Exynos4210 (TRATS) and Exynos4412 (TRATS2) > > Signed-off-by: Lukasz Majewski <[email protected]> > Signed-off-by: Tomasz Figa <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > > --- > Changes for v2: > - Proper definition of exynos_cpufreq_init() function to squash warnings
Looks good. Just one minor nit which I forgot to mention earlier. [snip] > > -static int __init exynos_cpufreq_init(void) > +static int exynos_cpufreq_init(struct platform_device *pdev) How about renaming this function to exynos_cpufreq_probe? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
