Em Thu, Nov 28, 2013 at 11:30:18AM +0100, Jiri Olsa escreveu: > Changing the file output code to use the newly > added perf_data_file__write interface. > > No functional change intended.
But there is one, if we fail the pr_err() will not be called, will some warning be emitter later on? If so, we should make it clear in the changelog. Lemme check by looking at that code... There are several places where the return of this function is propagated and handled with relevant error messages, but at least one, the most important, doesn't, i.e. this would be the only message the user would receive, can you verify that? - Arnaldo > Signed-off-by: Jiri Olsa <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Mike Galbraith <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Adrian Hunter <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > --- > tools/perf/builtin-record.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index d93e2ee..1be39e2 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -76,24 +76,17 @@ struct perf_record { > long samples; > }; > > -static int perf_record__write(struct perf_record *rec, void *buf, size_t > size) > +static ssize_t perf_record__write(struct perf_record *rec, > + void *buf, size_t size) > { > - struct perf_data_file *file = &rec->file; > - > - while (size) { > - ssize_t ret = write(file->fd, buf, size); > - > - if (ret < 0) { > - pr_err("failed to write perf data, error: %m\n"); > - return -1; > - } > - > - size -= ret; > - buf += ret; > + struct perf_session *session = rec->session; > + ssize_t ret; > > - rec->bytes_written += ret; > - } > + ret = perf_data_file__write(session->file, buf, size); > + if (ret < 0) > + return -1; > > + rec->bytes_written += ret; > return 0; > } > > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
