On 11/28, Ma, Xindong wrote:
>
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -412,16 +412,6 @@ void oom_kill_process(struct task_struct *p, gfp_t
> gfp_mask, int order,
> static DEFINE_RATELIMIT_STATE(oom_rs, DEFAULT_RATELIMIT_INTERVAL,
> DEFAULT_RATELIMIT_BURST);
>
> - /*
> - * If the task is already exiting, don't alarm the sysadmin or kill
> - * its children or threads, just set TIF_MEMDIE so it can die quickly
> - */
> - if (p->flags & PF_EXITING) {
> - set_tsk_thread_flag(p, TIF_MEMDIE);
> - put_task_struct(p);
> - return;
> - }
> -
> if (__ratelimit(&oom_rs))
> dump_header(p, gfp_mask, order, memcg, nodemask);
>
> @@ -437,6 +427,16 @@ void oom_kill_process(struct task_struct *p, gfp_t
> gfp_mask, int order,
> * still freeing memory.
> */
> read_lock(&tasklist_lock);
> + /*
> + * If the task is already exiting, don't alarm the sysadmin or kill
> + * its children or threads, just set TIF_MEMDIE so it can die quickly
> + */
> + if (p->flags & PF_EXITING) {
> + set_tsk_thread_flag(p, TIF_MEMDIE);
> + put_task_struct(p);
> + read_unlock(&tasklist_lock);
> + return;
> + }
I got lost... didn't we recently discussed the similar patch from Sameer?
This one doesn't look right. find_lock_task_mm() after unlock(tasklist)
can hit the same problem.
I belive the patch from Sameer was correct.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
