* Jiri Olsa <[email protected]> wrote: > On Fri, Nov 29, 2013 at 03:34:39PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Nov 28, 2013 at 12:33:00PM +0100, Jiri Olsa escreveu: > > > We use -fstack-protector-all option to enable stack protecting > > > for all available functions. There's no reason for enabling > > > -Wstack-protector to get warning for unprotected functions. > > > > > > Removing stackprotector feature check which was used to > > > enable the -Wstack-protector option. > > > > Doesn't applies to my perf/core branch. > > yep, that's that libunwind stuff messing up ;-) > > attaching v3, I could resend whole rebased patchset if > needed.. I also updated my perf/core_plugins branch > > thanks, > jirka > > > --- > We use -fstack-protector-all option to enable stack protecting > for all available functions. There's no reason for enabling > -Wstack-protector to get warning for unprotected functions. > > Removing stackprotector feature check which was used to > enable the -Wstack-protector option. > > Signed-off-by: Jiri Olsa <[email protected]> > Cc: Corey Ashford <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Steven Rostedt <[email protected]> > Cc: David Ahern <[email protected]> > --- > tools/perf/config/Makefile | 5 ----- > tools/perf/config/feature-checks/Makefile | 6 +----- > tools/perf/config/feature-checks/test-stackprotector.c | 6 ------ > 3 files changed, 1 insertion(+), 16 deletions(-) > delete mode 100644 tools/perf/config/feature-checks/test-stackprotector.c
Acked-by: Ingo Molnar <[email protected]> This should also speed up the feature tests by about 10-20 msecs in the test-all case. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
