On Fri, Nov 29, 2013 at 07:06:30PM +0530, Ramkumar Ramachandra wrote:
> Color the numbers in the Delta column using percent_color_snprintf().
> Generalize the function so that we can accommodate all three comparison
> methods in the future: delta, ratio, and wdiff.
>
> Cc: Jiri Olsa <jo...@redhat.com>
> Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
> Signed-off-by: Ramkumar Ramachandra <artag...@gmail.com>
> ---
> tools/perf/builtin-diff.c | 49
> ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 3b67ea2..c970aae 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -769,6 +769,45 @@ static int hpp__entry_baseline(struct hist_entry *he,
> char *buf, size_t size)
> return ret;
> }
>
> +static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
> + struct perf_hpp *hpp, struct hist_entry *he,
> + int comparison_method)
> +{
> + struct diff_hpp_fmt *dfmt =
> + container_of(fmt, struct diff_hpp_fmt, fmt);
> + struct hist_entry *pair = get_pair_fmt(he, dfmt);
> + double diff;
> + char pfmt[20] = " ";
> +
> + if (!pair)
> + goto dummy_print;
> +
> + switch(comparison_method){
> + case COMPUTE_DELTA:
> + if (pair->diff.computed)
> + diff = pair->diff.period_ratio_delta;
> + else
> + diff = compute_delta(he, pair);
> +
> + if (fabs(diff) < 0.01)
> + goto dummy_print;
> + scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
> + return percent_color_snprintf(hpp->buf, hpp->size,
> + pfmt, fabs(diff));
we dont want print fabs(diff).. we just want percent_color_snprintf
assign proper color for negative numbers, the change needs to go there
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
