Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: > Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim <namhyung....@lge.com> > > > > The --show-time-info option is for displaying elapsed sampling time > > Isn't that too long? Can't we use just --time/-t?
Hmm.. interesting. Your previous feedback was to use longer and clearer option name. :) https://lkml.org/lkml/2013/11/18/198 > > > information for each entry. > > > > $ perf record -- perf bench sched messaging > > $ perf report --stdio --show-time-info > > ... > > # Samples: 10K of event 'cycles' > > # Event count (approx.): 5118793536 > > # Total sampling time : 0.184277 (sec) > > # > > # Overhead Time Command Shared Object > > Symbol > > # ........ .......... ............... ................. > > ........................... > > # > > 7.26% 0.007413 sched-messaging [unknown] [.] > > 0x0000003153e7a6e7 > > 4.79% 0.006088 sched-messaging [kernel.kallsyms] [k] > > avc_has_perm_flags > > 4.38% 0.004809 sched-messaging [kernel.kallsyms] [k] > > copy_user_generic_string > > 3.81% 0.005457 sched-messaging [kernel.kallsyms] [k] > > _raw_spin_lock > > 2.92% 0.002745 sched-messaging [kernel.kallsyms] [k] > > _raw_spin_lock_irqsave > > 2.72% 0.002896 sched-messaging [kernel.kallsyms] [k] > > unix_stream_recvmsg > > 2.55% 0.003745 sched-messaging [kernel.kallsyms] [k] > > __slab_free > > 2.45% 0.002807 sched-messaging [kernel.kallsyms] [k] page_fault > > 2.08% 0.002258 sched-messaging [kernel.kallsyms] [k] > > sock_has_perm > > > > Signed-off-by: Namhyung Kim <namhy...@kernel.org> > > --- > > tools/perf/builtin-report.c | 2 ++ > > tools/perf/ui/hist.c | 68 > > +++++++++++++++++++++++++++++++++++++-------- > > tools/perf/util/hist.h | 1 + > > tools/perf/util/symbol.h | 3 +- > > 4 files changed, 62 insertions(+), 12 deletions(-) > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > index eb849e9f7093..345cce6f5fa2 100644 > > --- a/tools/perf/builtin-report.c > > +++ b/tools/perf/builtin-report.c > > @@ -898,6 +898,8 @@ int cmd_report(int argc, const char **argv, const char > > *prefix __maybe_unused) > > OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"), > > OPT_CALLBACK(0, "percent-limit", &report, "percent", > > "Don't show entries under that percent", > > parse_percent_limit), > > + OPT_BOOLEAN(0, "show-time-info", &symbol_conf.show_time_info, > > + "Show a column with the elapsed time"), > > OPT_END() > > }; > > struct perf_data_file file = { > > diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c > > index 78f4c92e9b73..7cf584a0bb61 100644 > > --- a/tools/perf/ui/hist.c > > +++ b/tools/perf/ui/hist.c > > @@ -7,19 +7,24 @@ > > #include "../util/evsel.h" > > > > /* hist period print (hpp) functions */ > > +enum hpp_fmt_type { > > + HPP_FMT__PERCENT, > > + HPP_FMT__RAW, > > + HPP_FMT__TIME, > > +}; > > I wonder if we can't make this a bitmask... Does it make sense to print > both percent and time, for instance? I'm not sure I understood you correctly, but did you mean printing both percent and time in a single column? This enum and the __hpp_fmt() function is for a single column. I can add a new column for time percent if you want. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
