On Thu, Jan 20, 2005 at 08:35:06AM -0500, Ed L Cashin wrote:
> Greg KH <[EMAIL PROTECTED]> writes:
>
> > On Wed, Jan 19, 2005 at 09:08:14AM -0500, Ed L Cashin wrote:
> >> > diff -Nru a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> >> > --- a/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> >> > +++ b/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> >> > @@ -249,6 +249,7 @@
> >> > aoeblk_exit(void)
> >> > {
> >> > kmem_cache_destroy(buf_pool_cache);
> >> > + unregister_blkdev(AOE_MAJOR, DEVICE_NAME);
> >> > }
> >>
> >> The unregister_blkdev should already be in aoemain.c:aoe_exit.
> >
> > Why? You do a register_blockdev() in this file, so if something fails,
> > you should also unregister here.
>
> No, the register_blkdev that you see in aoeblk.c is the artifact of a
> snafu I made in patch submission. I submitted a small patch yesterday
> (ID below) that corrects the snafu and makes block-2.6 the same as the
> driver I have.
>
> Message-ID: <[EMAIL PROTECTED]>
Ah, missed that as you didn't CC: me... I'll apply that one later on
today.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
