On Wed, Dec 04, 2013 at 01:50:34PM -0500, KOSAKI Motohiro wrote: > > @@ -1090,13 +1063,8 @@ void posix_cpu_timer_schedule(struct k_itimer *timer) > > timer->it.cpu.expires = 0; > > goto out_unlock; > > } else if (unlikely(p->exit_state) && thread_group_empty(p)) { > > - /* > > - * We've noticed that the thread is dead, but > > - * not yet reaped. Take this opportunity to > > - * drop our task ref. > > - */ > > + /* Optimizations: if the process is dying, no need to > > rearm */ > > cpu_timer_sample_group(timer->it_clock, p, &now); > > Why do we still need to call cpu_timer_sample_group? You removed to below > line which uses > "now".
Good point, it looks safe to remove it now. Thanks. > > - clear_dead_task(timer, now); > > goto out_unlock; > > } > > spin_lock(&p->sighand->siglock); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/