On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: > The other part I noticed about this particular patchset is that it's > not really "firmware" as such, but specifically PC wiht ACPI that > gets covered here. So rather than generalizing the code, another > option would be to narrow down the scope and make it > acpi_{warn,info,dbg} instead.
Making this specific to ACPI runs the risk of people introducing a multitude of new logging functions for every subsystem, e.g. efi_{warn,info,dbg}. FWIW, I'd be interested in using something like this patch series to properly log EFI implementation bugs. The logging for EFI is currently done fairly haphazardly. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/