agreed, the lack of a delimiter in the naming was annoying.
- kumar
On Jan 20, 2005, at 2:10 PM, Russell King wrote:
On Thu, Jan 20, 2005 at 11:50:58AM -0800, Greg KH wrote:
> On Thu, Jan 20, 2005 at 07:38:45PM +0000, Russell King wrote:
> >
> > Greg - the name is constructed from "name" + "id num" thusly:
> >
> > ��� serial8250
> > ��� serial82500
> > ��� serial82501
> > ��� serial82502
> >
> > When "name" ends in a number, it gets rather confusing.� Can we have
> > an optional delimiter in there when we append the ID number, maybe
> > something like a '.' or ':' ?
>
> Sure, that's fine with me.� Someone send me a patch :)
Like this? -
Separate platform device name from platform device number such that names ending with numbers aren't confusing.
Signed-off-by: Russell King <[EMAIL PROTECTED]>
--- orig/drivers/base/platform.c������� Wed Jan 12 10:11:20 2005
+++ linux/drivers/base/platform.c������ Thu Jan 20 20:08:53 2005
@@ -131,7 +131,7 @@ int platform_device_register(struct plat
������� pdev->dev.bus = &platform_bus_type;
�
������� if (pdev->id != -1)
-������ ������� snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s%u", pdev->name, pdev->id);
+������ ������� snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s.%u", pdev->name, pdev->id);
������� else
������� ������� strlcpy(pdev->dev.bus_id, pdev->name, BUS_ID_SIZE);
�
-- Russell King �Linux kernel��� 2.6 ARM Linux�� - http://www.arm.linux.org.uk/ �maintainer of:� 2.6 PCMCIA����� - http://pcmcia.arm.linux.org.uk/ ���������������� 2.6 Serial core
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
