On 12/5/13, Borislav Petkov <[email protected]> wrote: > Yes, the AER tracepoint above should use the AER_* defines and not the > HW_EVENT_ERR_* ones which are for memory errors. > > Wanna send a fix? >
Yes. Does it translate into something like this? From: Rui Wang <[email protected]> Date: Fri, 6 Dec 2013 16:47:46 +0800 Subject: [PATCH] Fix severity usage in aer trace event Signed-off-by: Rui Wang <[email protected]> --- include/trace/events/ras.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/ras.h b/include/trace/events/ras.h index 88b8783..e2a17d8 100644 --- a/include/trace/events/ras.h +++ b/include/trace/events/ras.h @@ -5,7 +5,7 @@ #define _TRACE_AER_H #include <linux/tracepoint.h> -#include <linux/edac.h> +#include <linux/aer.h> /* @@ -63,10 +63,10 @@ TRACE_EVENT(aer_event, TP_printk("%s PCIe Bus Error: severity=%s, %s\n", __get_str(dev_name), - __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" : - __entry->severity == HW_EVENT_ERR_FATAL ? + __entry->severity == AER_CORRECTABLE ? "Corrected" : + __entry->severity == AER_FATAL ? "Fatal" : "Uncorrected", - __entry->severity == HW_EVENT_ERR_CORRECTED ? + __entry->severity == AER_CORRECTABLE ? __print_flags(__entry->status, "|", aer_correctable_errors) : __print_flags(__entry->status, "|", aer_uncorrectable_errors)) ); -- 1.7.5.4 Regards, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
