On 2005.01.20, Ingo Molnar wrote: > > this patch would have caught the bug in -BK-curr (that patch #1 fixes), > via a compiler warning. Test-built/booted on x86. > > Ingo > > Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> > > --- linux/include/asm-i386/spinlock.h.orig > +++ linux/include/asm-i386/spinlock.h > @@ -36,7 +36,10 @@ typedef struct { > > #define SPIN_LOCK_UNLOCKED (spinlock_t) { 1 SPINLOCK_MAGIC_INIT } > > -#define spin_lock_init(x) do { *(x) = SPIN_LOCK_UNLOCKED; } while(0) > +static inline void spin_lock_init(spinlock_t *lock)
Will have any real effect if you add things like: +static inline void spin_lock_init(spinlock_t *lock) __attribute__((__pure__)); ?? TIA -- J.A. Magallon <jamagallon()able!es> \ Software is like sex: werewolf!able!es \ It's better when it's free Mandrakelinux release 10.2 (Cooker) for i586 Linux 2.6.10-jam4 (gcc 3.4.3 (Mandrakelinux 10.2 3.4.3-3mdk)) #2
pgp7L3hBDpJiT.pgp
Description: PGP signature