2013/12/6 Chen-Yu Tsai <w...@csie.org>:
> The CubieTruck uses the GMAC with an RGMII phy.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
> ---
> arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 8a1009d..af212a2 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -33,6 +33,14 @@
> pinctrl-0 = <&uart0_pins_a>;
> status = "okay";
> };
> +
> + gmac: ethernet@01c50000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac_pins_rgmii>;
> + snps,phy-addr = <1>;
What is this snps,phy-addr property? Why is not a standard device tree
node for an Ethernet PHY node used?
> + phy-mode = "rgmii";
Especially since you use the relatively standard "phy-mode" property here?
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
