On 2013年12月10日 09:01, David Miller wrote:
From: fre...@asix.com.tw
Date: Fri, 6 Dec 2013 17:58:18 +0800
From: Freddy Xin <fre...@asix.com.tw>
The AX88179_178A has a hardware feature that it can insert a 2-bytes pseudo
header in front of each received frame by setting the AX_RX_CTL_IPE bit.
This feature is used to let the IP header be aligned on a doubleword-aligned
address,
but the NET_IP_ALIGN may equals to 2 and the __netdev_alloc_skb_ip_align in
USBNET will
reserve 2 bytes also, so in this case the driver shouldn't enable this bit.
This patch modifies the driver to set AX_RX_CTL_IPE just in case of the
NET_IP_ALIGN equals 0.
Signed-off-by: Freddy Xin <fre...@asix.com.tw>
Please avoid larger than 80 column lines in your commit messages,
people use text-only tools to viee these.
Next, it makes no sense to restrict your change to NET_IP_ALIGN==0
Simply handle any case, by undoing the reservation if it's getting
in the way. If there isn't an appropriate helper for this, add one.
I think there is no way of undoing the reservation in the driver.
Can I add a flag of the driver_info, and use it to determine
whether undoing the reservation in rx_submit of usbnet?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
