On Thu, Dec 12, 2013 at 12:46 AM, tedheadster <[email protected]> wrote: > On Thu, Dec 12, 2013 at 3:39 AM, Olof Johansson <[email protected]> wrote: >> >> Commit c45f812f0280 ('8390 : Replace ei_debug with msg_enable/NETIF_MSG_* >> feature') ended up moving the printout of version[] from something that >> will be compiled out due to defines, to something that is now evaluated >> at runtime. >> >> That means that what always used to be an access to an __initdata string >> from non-__init code started showing up as a section mismatch when it >> didn't before. >> >> All other 8390 versions skip __initdata on the version string, and >> starting to annotate the whole chain of callers with __init seems like >> more churn than it's worth on this driver, so remove it from etherh.c as >> well. >> > > Olof, > should you also remove the __init tag from etherh_banner() since it is > called from etherh_probe(), which does not have an __init tag?
Hmm. The section warning functionality is clever enough to not trigger when a function is named _probe() and references __initdata, and discarding etherh_banner() should be just fine so I don't see a need to remove it. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
