On 11/12/13 21:41, David Ahern wrote: > On 12/11/13, 5:37 AM, Alexander Shishkin wrote: >> From: Adrian Hunter <adrian.hun...@intel.com> >> >> If a file contains Instruction Tracing data then always allow >> fields 'addr' and 'cpu' to be selected as options for perf >> script. This is necessary because Instruction Trace decoding >> may synthesize events with that information. > > Why hardcode it? If it is present and the user opts for it then it will be > printed. Why is the itrace check needed?
itrace synthesizes events, so the events do not exist until the decoding starts, thus the validation prevents you from having 'addr' or 'cpu' even though they will show up in events later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
