On 12/12/13, 10:26 AM, Ramkumar Ramachandra wrote:
Introduce
$ perf kvm --list-cmds
to dump a raw list of commands for use by the completion script. While
at it, refactor kvm_usage so that there's only one copy of the command
listing.
Cc: David Ahern <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
David Ahern wrote:
> That would work -- perhaps a #define or string near
>
> const char * const kvm_usage[] = {
> "perf kvm [<options>] {top|record|report|diff|buildid-list|stat}",
> NULL
> };
>
> Building kvm_usage from the string would better - only 1 place listing the
> commands.
Something like this, perhaps? It's not too pretty though: do you have
suggestions to prettify it?
tools/perf/builtin-kvm.c | 25 +++++++++++++++++++++----
tools/perf/perf-completion.sh | 2 +-
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index c6fa3cb..ce44a9b 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1672,6 +1672,7 @@ __cmd_buildid_list(const char *file_name, int argc, const
char **argv)
int cmd_kvm(int argc, const char **argv, const char *prefix __maybe_unused)
{
const char *file_name = NULL;
+ bool list_cmds = false;
const struct option kvm_options[] = {
OPT_STRING('i', "input", &file_name, "file",
"Input file name"),
@@ -1692,20 +1693,36 @@ int cmd_kvm(int argc, const char **argv, const char
*prefix __maybe_unused)
"file", "file saving guest os /proc/modules"),
OPT_INCR('v', "verbose", &verbose,
"be more verbose (show counter open errors, etc)"),
+ OPT_BOOLEAN(0, "list-cmds", &list_cmds,
+ "list commands raw for use by scripts"),
OPT_END()
};
+ const char *const commands[] = { "top", "record", "report", "diff",
+ "buildid-list", "stat", NULL };
Building it is kind of ugly looking.
Arnaldo: what about this:
#define KVM_CMDS "top record report diff buildid-list stat"
+ char kvm_usage_str[80];
+ const char *kvm_usage[] = { NULL, NULL };
- const char * const kvm_usage[] = {
- "perf kvm [<options>]
{top|record|report|diff|buildid-list|stat}",
- NULL
const char * const kvm_usage[] = {
"perf kvm [<options>] <command>, command = " KVM_CMDS,
NULL
I would even be fine with not touching kvm_usage and having the KVM_CMDS
macro right above it -- changing one causes the other to show up in a diff.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
