On Sat, Dec 14, 2013 at 05:15:34PM +0300, Dan Carpenter wrote: > On Sat, Dec 14, 2013 at 06:56:10PM +0530, Rashika Kheria wrote: > > This patch marks the function of_reset_simple_xlate() and > > devm_reset_control_put() as static in core.c because it is not used > > outside this file. > > > > Thus, it also eliminate the following warnings in core.c: > > drivers/reset/core.c:46:5: warning: no previous prototype for > > ‘of_reset_simple_xlate’ [-Wmissing-prototypes] > > drivers/reset/core.c:262:6: warning: no previous prototype for > > ‘devm_reset_control_put’ [-Wmissing-prototypes] > > > > These are EXPORT_SYMBOL_GPL() so that doesn't make sense. > devm_reset_control_put() is not used at all and of_reset_simple_xlate() > doesn't look like it needs to be exported. Philipp?
That sounds like the right fix to me: drop devm_reset_control_put and its export completely, and drop the export of make of_reset_simple_xlate. Unless there's some relevant out-of-tree caller of either function, that seems sensible. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
