On 12/13/2013 11:52 PM, Steven Rostedt wrote:
> On Fri, 13 Dec 2013 10:50:23 -0500
> Steven Rostedt <rost...@goodmis.org> wrote:
> 
>> On Fri, 13 Dec 2013 15:41:04 +0000
>> Will Deacon <will.dea...@arm.com> wrote:
>>
>>>> +#include <linux/kernel.h>
>>>> +#include <linux/jump_label.h>
>>>> +#include <asm/jump_label.h>
>>>> +#include <asm/insn.h>
>>>> +
>>>> +#ifdef HAVE_JUMP_LABEL
>>>
>>> Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did
>>> you manage to test this code?
>>
>> In <linux/jump_label.h> we have:
>>
>> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
>>
>> [...]
>>
>> # include <asm/jump_label.h>
> 
> This also makes the include of <asm/jump_label.h> in the C file
> redundant.
> 
> -- Steve
Thanks, Steve.
Will remove the redundant include header file.

> 
>> # define HAVE_JUMP_LABEL
>> #endif       /* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */
>>
>>
>> -- Steve
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to