On Wed, Dec 18, 2013 at 12:04 AM, Jan Beulich <[email protected]> wrote: >>>> On 17.12.13 at 23:34, "Luck, Tony" <[email protected]> wrote: >>> No, it hasn't. But I explicitly checked the relevant EFI=n and EFI=y >>> cases. >> >> I pushed your patch into my "next" tree - the robots will notice soon and >> send us e-mail if they find any issues. > > Thanks, Tony. I'm afraid though that fixing this only in 3.14 would > be a little late: Any "select" in a Kconfig results in the user not being > asked again when that "select" goes away, so people having got EFI > forcibly enabled in 3.13 and updating their configs to 3.14 would > then need to remember to manually disable CONFIG_EFI again (of > course that's already true for anyone using 3.13-rc?, but those > should mostly be people more knowledgeable than folks just > consuming final releases). > > I think it should generally be the exception to "select" options that > have visible prompts (i.e. are user configurable).
Ingo: Jan makes a good point that people running "make oldconfig" may get suckered into selecting CONFIG_EFI when they don't really need it. I've not seen any complaints from the robot randconfig testers, so this patch is: Acked-by: Tony Luck <[email protected]> Can you push it to Linus before 3.13-final releases? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
