Hi Jiri, On Wed, 18 Dec 2013 16:50:40 +0100, Jiri Olsa wrote: > On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim <namhyung....@lge.com> >> >> There're some duplicate code when adding hist entries. They are >> different in that some have branch info or mem info but generally do >> same thing. So introduce new struct add_entry_iter and add callbacks >> to customize each case in general way. >> >> The new perf_evsel__add_entry() function will look like: >> >> iter->prepare_entry(); >> iter->add_single_entry(); >> >> while (iter->next_entry()) >> iter->add_next_entry(); >> >> iter->finish_entry(); >> >> This will help further work like the cumulative callchain patchset. > > cool, I was waiting for this one! I have another user > for it, I'll test by rebasing my code ;-)
Great! I'd look forward to your feedback! :) Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
