On Mon, 2013-12-23 at 18:53 -0600, Derek Perrin wrote: > On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote: > > On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: [] > > One trivial bit too, > > > diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c [] > > > - ssize_t(*show) (struct edd_device * edev, char *buf); > > > - int (*test) (struct edd_device * edev); > > > + ssize_t(*show) (struct edd_device *edev, char *buf); > > > + int (*test) (struct edd_device *edev); > > > > I think most prefer function pointer prototypes like: > > > > size_t (*show)(struct edd_device *edev, char *buf); > > int (*test)(struct edd_device *edev);
> I'm not seeing any > difference between what I did and what you said about the function pointer > prototypes. type (*funcptr) (args...) vs type (*funcptr)(args...) 2nd is preferred -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/