On Mon, Dec 23, 2013 at 10:55:16PM +0000, Ben Hutchings wrote: > On Mon, 2013-12-23 at 08:29 -0500, Neil Horman wrote: > > The SCTP protocol has several deprecation warnings in its setsockopt path > > that > > can be triggered by unprivlidged users. Since these are not ratelimited, > > we can > > spam the logs quite easily here. Since these are all deprecation warnings, > > and > > that type of warning isn't uncommon in the rest of the kernel, lets make a > > common pr_warn_deprecated macro to produce somewhat generalized ratelimited > > deprecation warnings easily > [...] > > No objection to these changes, but I think deprecation warnings should > log at least the command name and maybe also the pid of the caller. > I didn't change the contents of the strings in this patch, I just wanted to avoid log spamming, but I think adding caller pid/name is a good idea. I'll do that in a followon patch after the holidays Neil
> Ben. > > -- > Ben Hutchings, Staff Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
