On Thu, Dec 26, 2013 at 11:20:31AM -0800, Joe Perches wrote:
> If statements don't need multiple parentheses around tested
> comparisons like "if ((foo == bar))".
>
> An == comparison maybe a sign of an intended assignment,
> so emit a slightly different message if so.
>
> Signed-off-by: Joe Perches <j...@perches.com>
Reviewed-by: Josh Triplett <j...@joshtriplett.org>
> scripts/checkpatch.pl | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index db72b88..c12234e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3322,6 +3322,20 @@ sub process {
> }
> }
>
> +# if statements using unnecessary parentheses - ie: if ((foo == bar))
> + if ($^V && $^V ge 5.10.0 &&
> + $line =~ /\bif\s*((?:\(\s*){2,})/) {
> + my $openparens = $1;
> + my $count = $openparens =~ tr@\(@\(@;
> + my $msg = "";
> + if ($line =~
> /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/)
> {
> + my $comp = $4; #Not $1 because of $LvalOrFunc
> + $msg = " - maybe == should be = ?" if ($comp eq
> "==");
> + WARN("UNNECESSARY_PARENTHESES",
> + "Unnecessary parentheses$msg\n" .
> $herecurr);
> + }
> + }
> +
> # Return of what appears to be an errno should normally be -'ve
> if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
> my $name = $1;
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
