On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: "David S. Miller" <da...@davemloft.net> > Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> > --- > drivers/net/plip/plip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c > index 7b4ff35..26614df 100644 > --- a/drivers/net/plip/plip.c > +++ b/drivers/net/plip/plip.c > @@ -549,7 +549,7 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct > net_device *dev) > > if(*eth->h_dest&1) > { > - if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0) > + if(ether_addr_equal(eth->h_dest, dev->broadcast)) > skb->pkt_type=PACKET_BROADCAST; > else > skb->pkt_type=PACKET_MULTICAST;
What about : if (is_multicast_ether_addr(eth->h_dest)) { if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast)) skb->pkt_type = PACKET_BROADCAST; else skb->pkt_type = PACKET_MULTICAST; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/