Looks good. Acked by: Sujith Sankar <ssuj...@cisco.com>
On 30/12/13 1:42 PM, "Govindarajulu Varadarajan (gvaradar)" <gvara...@cisco.com> wrote: >On Mon, 30 Dec 2013, Ding Tianhong wrote: > >> Use possibly more efficient ether_addr_equal >> to instead of memcmp. >> >> Cc: Christian Benvenuti <be...@cisco.com> >> Cc: Sujith Sankar <ssuj...@cisco.com> >> Cc: Govindarajulu Varadarajan <govindarajul...@gmail.com> >> Cc: Neel Patel <neepa...@cisco.com> >> Cc: Nishank Trivedi <nistr...@cisco.com> >> Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> >> --- >> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c >>b/drivers/net/ethernet/cisco/enic/enic_pp.c >> index 43464f0..e6a8319 100644 >> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c >> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c >> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct >>enic_port_profile *pp1, >> return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid, >> pp2->instance_uuid, PORT_UUID_MAX) | >> !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) | >> - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); >> + !ether_addr_equal(pp1->mac_addr, pp2->mac_addr); >> } >> >> static int enic_pp_preassociate(struct enic *enic, int vf, >> -- >> 1.8.0 >> > >looks good for me > >Acked-by: Govindarajulu Varadarajan <govindarajul...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
