On Fri, Jan 3, 2014 at 1:57 AM, Joe Perches <j...@perches.com> wrote: > (Adding Kay to cc's) > > Kay? any opinion on correctness?
Sounds fine by looking at it. Did not test anything though. >> > --- a/kernel/printk/printk.c >> > +++ b/kernel/printk/printk.c >> > @@ -1604,7 +1604,10 @@ asmlinkage int vprintk_emit(int facility, int level, >> > if (!(lflags & LOG_PREFIX)) >> > stored = cont_add(facility, level, text, text_len); >> > cont_flush(LOG_NEWLINE); >> > - } >> > + /* Flush conflicting buffer. An earlier newline was missing >> > + * and current print is from different task */ >> > + } else if (cont.len && cont.owner != current) >> > + cont_flush(LOG_NEWLINE); Unless I miss something, this whole sections all go inside a: if (cont.len) { ... cont_flush(LOG_NEWLINE); } and look a bit less confusing than the two conditions with just the negated "current" check and duplicated flush call? Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/