On Tue, 25 Jan 2005, George Anzinger wrote: > > Your patch breaks the mmtimer driver because it used k_itimer values for > > its own purposes. Here is a fix by defining an additional structure > > in k_itimer (same approach for mmtimer as the cpu timers): > > I would like to get a read on the following defines... > #define mmclock mmtimer.clock > #define mmnode mmtimer.node > #define mmincr mmtimer.incr > #define mmexpires mmtimer.expires > > Then, of course, you would use the defines instead of the "." references. Is > this a big no-no in kernel code. Seems to me it makes things a bit easier to > read.
Less code to get to the values would be preferable. Maybe this could be another patch to clean up the clock driver stuff and provide some standardized mechanism to provide private data space for future clock drivers? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/