On Sun, 5 Jan 2014 17:45:46 +0100, Jiri Olsa wrote: > On Tue, Dec 24, 2013 at 05:22:09PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim <[email protected]> >> >> Maintain accumulated stat information in hist_entry->stat_acc if >> symbol_conf.cumulate_callchain is set. Fields in ->stat_acc have same >> vaules initially, and will be updated as callchain is processed later. >> >> Cc: Arun Sharma <[email protected]> >> Cc: Frederic Weisbecker <[email protected]> >> Signed-off-by: Namhyung Kim <[email protected]> >> --- >> tools/perf/util/hist.c | 18 ++++++++++++++++++ >> tools/perf/util/sort.h | 1 + >> tools/perf/util/symbol.h | 1 + >> 3 files changed, 20 insertions(+) >> >> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c >> index 283aa1972b4f..b61e2fa42412 100644 >> --- a/tools/perf/util/hist.c >> +++ b/tools/perf/util/hist.c >> @@ -237,6 +237,8 @@ static bool hists__decay_entry(struct hists *hists, >> struct hist_entry *he) >> return true; >> >> he_stat__decay(&he->stat); >> + if (symbol_conf.cumulate_callchain) >> + he_stat__decay(he->stat_acc); >> >> if (!he->filtered) >> hists->stats.total_period -= prev_period - he->stat.period; >> @@ -284,6 +286,15 @@ static struct hist_entry *hist_entry__new(struct >> hist_entry *template) > > there's callchain size computation in here: > size_t callchain_size = symbol_conf.use_callchain ? sizeof(struct > callchain_root) : 0; > > I wonder we could make it zero for symbol_conf.cumulate_callchain
The plan is to support callchain with --children enabled. :) Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
