What for? Please be clear in the changelogs, it helps with review. Now I'll have to follow the logic to figure this out, i.e. _why_ we should free aliases[j] if name_only is true? Is it safe?
- Arnaldo Em Mon, Dec 30, 2013 at 10:26:38AM -0500, Dongsheng Yang escreveu: > Signed-off-by: Dongsheng Yang <yangds.f...@cn.fujitsu.com> > --- > tools/perf/util/pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 331dc2c..169c480 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -752,6 +752,7 @@ unsigned int print_pmu_events(const char *event_glob, > bool name_only) > for (j = 0; j < len; j++) { > if (name_only) { > printf("%s ", aliases[j]); > + zfree(&aliases[j]); > count++; > continue; > } > -- > 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/