Hello Tomasz, On 8 January 2014 06:02, Tomasz Figa <[email protected]> wrote: > On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote: >> From: Naveen Krishna Chatradhi <[email protected]> >> >> this patch adds the device tree nodes for SSS module found on Exynos5420 > > nit: Sentences in English start with a capital letter. Also this patch > adds one node, not few of them as the description suggests. > > Also patch subject should start with ARM: dts: prefix. > >> >> Signed-off-by: Naveen Krishna Chatradhi <[email protected]> >> TO: <[email protected]> >> CC: Kukjin Kim <[email protected]> >> CC: <[email protected]> >> --- >> arch/arm/boot/dts/exynos5420.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >> b/arch/arm/boot/dts/exynos5420.dtsi >> index 11dd202..97045f9 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -652,4 +652,14 @@ >> clocks = <&clock 319>, <&clock 318>; >> clock-names = "tmu_apbif", "tmu_triminfo_apbif"; >> }; >> + >> + sss: sss { > > Node name should be sss@10830000 as per ePAPR node naming recommendation. Thanks for the correction, Will correct it and submit. Thanks > > Best regards, > Tomasz >
-- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
