On Wed, Jan 08, 2014 at 07:13:10AM +0800, Wang YanQing wrote:
> After a5f4f52e82114e85aa1a066bd1a450acc19a464d
> ("vt: use kzalloc() instead of the bootmem allocator"),
> con_init began to use kzalloc to initialize vc_data,
> this patch convert con_init to use vc_allocate.
>
> The benefit we get:
> 1: reduce code duplication
> 2: vc_allocate is more robust
> 3: use kmalloc instead of kzalloc for vc_screenbuf
>
> Signed-off-by: Wang YanQing <[email protected]>
> ---
> this patch don't have v2 :) I jump to v3 directly
> from v1, but I keep the mistake for less confusion.
>
> Changes v3-v4:
> 1: use bool/true/false instead of int/1/0
>
> Thanks for Jiri Slaby
>
> drivers/tty/vt/vt.c | 28 ++++++++++++++--------------
> drivers/tty/vt/vt_ioctl.c | 8 ++++----
> include/linux/vt_kern.h | 2 +-
> 3 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 15aaa01..c0d6255 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -748,7 +748,8 @@ static void visual_init(struct vc_data *vc, int num, int
> init)
> vc->vc_screenbuf_size = vc->vc_rows * vc->vc_size_row;
> }
>
> -int vc_allocate(unsigned int currcons) /* return 0 on success */
> +/* return 0 on success */
> +int vc_allocate(unsigned int currcons, bool early)
What does "early" mean? I understand the goal of making the code
smaller (hint, it's the same size overall with this change), but adding
flags like this just makes things a whole lot harder to debug and
understand later on.
I really don't like this as it adds to the programmer's complexity at
the tradeoff of a chance at smaller code.
sorry,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
