On Sat, 11 Jan 2014 17:24:08 +0100, Jiri Olsa wrote: > On Wed, Jan 08, 2014 at 05:46:28PM +0900, Namhyung Kim wrote: >> Now the hist_entry_iter code will be shared with perf top code base. >> So move it to util/hist.c and do some necessary cleanups and renames. > > factoring code from this very patchset.. looks like it could be easily > squashed with: > perf tools: Introduce struct hist_entry_iter
OK, I'll squash it. It was a result of extending it to support perf top but yes, it'd be better if it's in the separate code from the beginning. [SNIP] >> @@ -555,23 +103,19 @@ static int process_sample_event(struct perf_tool *tool, >> return 0; >> >> if (sort__mode == SORT_MODE__BRANCH) >> - iter = &branch_iter; >> + iter = &hist_iter_branch; >> else if (rep->mem_mode == 1) >> - iter = &mem_iter; >> + iter = &hist_iter_mem; >> else if (symbol_conf.cumulate_callchain) >> - iter = &cumulative_iter; >> + iter = &hist_iter_cumulative; >> else >> - iter = &normal_iter; >> + iter = &hist_iter_normal; > > looks like we could add 'struct hist_entry_iter_ops' and ops > pointer in 'struct hist_entry_iter' ...just feel better ;-) Yes, it looks better - I'll change it too. Thanks for your review! Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
