Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c

[Joe Perches]

On Mon, 2014-01-13 at 15:56 -0800, Greg KH wrote:
> On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote:
[]
> > diff --git a/drivers/staging/ced1401/ced_ioc.c 
> > b/drivers/staging/ced1401/ced_ioc.c
[]
> > @@ -41,7 +41,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
> >  {
> >     dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
> >             pdx->sCurrentState);
> > -   if (pdx->sCurrentState == U14ERR_TIME)  /* Do nothing if hardware in 
> > trouble */
> > +   if (pdx->sCurrentState == U14ERR_TIME)
> > +           /* Do nothing if hardware in trouble */
> >             return;
> 
> Please wrap stuff like this in { } to not confuse people.

Yes please, or maybe put the comment on the return line like:

        if (pdx->sCurrentState == U14ERR_TIME)
                return;                 /* Do nothing if hardware in trouble */

or above the test like:

        /* Do nothing if hardware in trouble */
        if (pdx->sCurrentState == U14ERR_TIME)
                return;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/