Roland Dreier wrote:
Reading through the tree, I see that some callers of get_user_pages() release the pages that they got via put_page(), and some callers use page_cache_release(). Of course <linux/pagemap.h> has
#define page_cache_release(page) put_page(page)
so this is really not much of a difference, but I'd like to know which is considered better style. Any opinions?
I've defined this function. I'm not sure if it really works, but it looks good.
#include <linux/pagemap.h>
void put_user_pages(int len, struct page **pages)
{
int i; for (i=0; i<len; i++) {
if (!PageReserved(pages[i])) {
SetPageDirty(pages[i]);
}
page_cache_release(pages[i]);
}
}-- Timur Tabi Staff Software Engineer [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
