On 1/21/2014 1:32 PM, Aravind Gopalakrishnan wrote:
On 1/20/2014 1:07 AM, Ingo Molnar wrote:
* Aravind Gopalakrishnan <aravind.gopalakrish...@amd.com> wrote:
+
+#if defined(CONFIG_PCI)
+/*
+ * Apply AMD Fam16h Erratum792
+ * see Revision Guide for AMD F16h models 00h-0fh,
+ * document 51810 rev. 3.04, Nov 2013
+ */
+static void quirk_amd_dram_scrub(struct pci_dev *dev)
The reference to the erratum is useful for people who want to see more
details, but at least a short description of the problem being fixed
and systems affected by the quirk is needed. 'DRAM scrub' is not very
informative.
Ok, I'll reword the comment in a V2.
But there's an internal discussion going on about the erratum, so I'll
hold off spinning a V2 until that's over..
Thanks,
-Aravind.
Addressing hpa and Boris' earlier concern
(http://marc.info/?l=linux-kernel&m=138998314409664&w=2)
I can say with better certainty now that there is a coverage hole:
Initial production parts shipped last year, while fix will be in BIOS
only from now onwards; (at least server platforms..)
I have also reworded the comment and function name per Ingo's suggestion..
Sending V2 of patch (rebased off latest tip/master)
Thanks,
-Aravind
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
