On Sun, Jan 26 2014, Christoph Hellwig wrote: > On Fri, Jan 24, 2014 at 11:11:29AM -0800, Jens Axboe wrote: > > It is pretty much the same. I don't like the semantics of the old one, > > where it's 0/1/2 for off/on/different-on, though. Seems like now would > > be a good time to clean it up. > > I don't think arbitrarily breaking this fairly widely used interface > when a driver is moving to blk-mq sounds like a good idea. Maybe we > should allow for setting descriptive strings as well?
Yeah, that's a good idea. We could retain the 0/1/2 for compat reasons, but have it present strings instead. > Also the different on semantics do matter for some use cases, and we > should support both for blk-mq. Certainly, not disagreeing with that. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
