On Thu, 30 Jan 2014 14:04:12 -0800 (PST) David Rientjes <[email protected]> wrote:
> On Thu, 30 Jan 2014, Andrew Morton wrote: > > > > Yeah, it shouldn't be temporary it should be the one and only allocation. > > > > > > We should construct the name in memcg_create_kmem_cache() and be done > > > with > > > it. > > > > Could. That would require converting memcg_create_kmem_cache() to take > > a va_list and call kasprintf() on it. > > > > Why? We already construct the name in memcg_create_kmem_cache() > appropriately, we just want to avoid the kstrdup() in > kmem_cache_create_memcg() since it's pointless like my patch does. oh, OK, missed that. The problem now is that the string at kmem_cache.name is PATH_MAX bytes, and PATH_MAX is huuuuuuuge. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
